feat(sdl): move validation from cloudmos to sdl (#133) #82
Conversation
ygrishajev
force-pushed
the
feature/sdl
branch
2 times, most recently
from
b345e4d to
245f7a9
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #82 +/- ##
===========================================
+ Coverage 54.01% 70.85% +16.83%
===========================================
Files 15 21 +6
Lines 648 741 +93
Branches 171 201 +30
===========================================
+ Hits 350 525 +175
+ Misses 298 208 -90
- Partials 0 8 +8 ☔ View full report in Codecov by Sentry. |
ygrishajev
changed the title
ygrishajev
changed the title
As part of this: - run validation on the class init - add deprecation warning to static validation method - move along necessary deps types and deps from cloudmos
ygrishajev
force-pushed
the
feature/sdl
branch
3 times, most recently
from
6ce2a4b to
5486eab
Compare
src/sdl/index.ts
Outdated
| const { credentials } = this.data.services[serviceName]; | ||
|
|
||
| if (credentials) { | ||
| const credentialsKeys: (keyof v2ServiceImageCredentials)[] = ["host", "username", "password"]; |
There was a problem hiding this comment.
There was a problem hiding this comment.
It is there in type, however its not validated in node akash-network/node@6e68af0#diff-346f62ceedbdbca807c73a4314af6b8da932fdb8ee2e91c92dbecd5c2745f24aR190
so i skipped any validation here too
There was a problem hiding this comment.
so is this fine @baktun14 ?
There was a problem hiding this comment.
Ah ok I guess yea, this is intended? @troian
ygrishajev
force-pushed
the
feature/sdl
branch
3 times, most recently
from
04f0158 to
e1b055a
Compare
also improve basic yml templating with default values refs akash-network/console#133
|
🎉 This PR is included in version 0.8.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Changes:
Note: